Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase connection buffer size to 2000 #3439

Merged
merged 1 commit into from
May 23, 2023

Conversation

simonwicky
Copy link
Contributor

Description

Closes: #3433

@simonwicky simonwicky requested review from octol and jstuczyn May 23, 2023 11:37
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this first PR

@octol octol modified the milestone: 2023.23 May 23, 2023
@jstuczyn jstuczyn modified the milestone: 2023.22 May 23, 2023
@simonwicky simonwicky merged commit a55d604 into develop May 23, 2023
@simonwicky simonwicky deleted the simon/feature/connection-buffer-size branch May 23, 2023 14:08
durch added a commit that referenced this pull request May 27, 2023
commit 5bd87bd
Author: pierre <dommerc.pierre@gmail.com>
Date:   Sat May 27 00:00:17 2023 +0200

    feat(nc-native-android): add notification tap action

    on notification tap, bring app to foreground
    use a shield icon for the top bar app icon
    clean code
    add notes on a pending bug

commit 7d64618
Author: omahs <73983677+omahs@users.noreply.github.com>
Date:   Fri May 26 15:46:08 2023 +0200

    Fix: typos (#3143)

    * Fix: typos

    * Fix: typos

    * Fix: typo

commit 4151c65
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Fri May 26 11:01:17 2023 +0200

    Add nym-socks5-listener to main workspace (#3455)

    * Add nym-socks5-listener to main workspace

    * add socks5-listener to CI build path trigger

    * Using repr(u8) instead of repr(C) for ClientState enum

    ---------

    Co-authored-by: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com>

commit ccb48f9
Author: Fouad <fmtabbara@hotmail.co.uk>
Date:   Fri May 26 09:16:28 2023 +0100

    fix sp drop down list (#3454)

commit 8fce478
Author: pierre <dommerc.pierre@gmail.com>
Date:   Fri May 26 00:34:40 2023 +0200

    doc(nc-native-android): add readme

commit 4f712ad
Author: pierre <dommerc.pierre@gmail.com>
Date:   Thu May 25 23:14:11 2023 +0200

    fix(android-native): crash on android 11

commit 562fd44
Author: pierre <dommerc.pierre@gmail.com>
Date:   Thu May 25 23:00:36 2023 +0200

    fix(android-native): crash on android 11

commit 603e897
Author: pierre <dommerc.pierre@gmail.com>
Date:   Thu May 25 18:03:20 2023 +0200

    build(android-native): add split abi config

    refactor android build script

commit 6c122aa
Author: Pierre Dommerc <dommerc.pierre@gmail.com>
Date:   Thu May 25 18:00:22 2023 +0200

    add nym ic launcher (#3456)

commit b4ac601
Merge: ce380a6 5b02801
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Thu May 25 15:58:14 2023 +0200

    Merge remote-tracking branch 'origin/release/v1.1.20' into develop

commit ce380a6
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Thu May 25 15:45:40 2023 +0200

    Native nym-connect clients for iOS and Android (initial version) (#3452)

    * initial crate

    * foomp

    * Make it work for x86_64-linux-android

    * remove unused stuff

    * Add header

    * another layer of hacks

    * additional target os locking

    * cleanup

    * bootstrap android app

    * android jni function

    * instructions + xcode project

    * update jni name

    * add native socks5 class

    * typo

    * gitkeep android native lib path

    * add native socks5 class

    * add socks5 native lib in java

    * add build script

    * fix jni dependency declaration

    * wip

    * Update build.sh

    * Move build.sh to new subdir

    * rename to build-android.sh

    * fix typo in FFI function name

    * use a good SP

    * wip not crashing state

    * add android network permissions

    * android_logging

    * starting client on button in swift + safer ffi

    * set tag for libnyms5 logs

    * testing callbacks

    * android: start socks5 process in a separated thread

    * non-blocking client with callbacks

    * Remove the old non-working logger

    * Restore commented out functionality in socks5 client

    * basic file write/load + possible android fix

    * Fully working state (minus task manager)

    * Remove unused function

    * data persistence + cb with address

    * Remove stray old MyClass file from the merge

    * Make storage_dir and Option

    * Fix char_p for android

    * Android now works with the new branch

    * Tidy up a little in the jni code

    * Move android mod to seperate file

    * jni wrap start/stop

    * Add android build to Makefile

    * android: add basic UI and start/stop actions

    * typo

    * add nym word

    * dirty persistence restored

    * dirty android fixes

    * even dirtier workaround

    * Move rust crate to sdk/lib

    * Update cargo.toml

    * Strip release binary

    * Update lib name in android project

    * Move ios project to nym-connect directory

    * remove old gitignore file

    * Move ios client one step deeper

    * fixed xcode lib paths

    * removed old tracked file

    * move android app under new path

    * a bit of cleanup

    * hopefully fixing the CI issues (🤞)

    * Update Makefile

    * android: add better support for persistent state

    * updating ios UI on ffi callbacks

    * missing dead code

    * Added toggle button (wip)

    * swapped connect and disconnect  methods around

    * icon

    * fixed android build

    * reset button + reuse service provider

    * disabling reset button

    * android: run proxy in a worker as foreground service

    * todo user cancel action

    * android build script: add aarch64

    * add stop action from notification

    * add simple callbacks to the socks5 bridge

    * pick a sp randomly

    * pass stop cb to lib call

    * add loading state support

    * refactor(android): base connection state on callback calls

    * android: add optimistic ui

    * android: unique instance of libnym

    * removing deadcode

    ---------

    Co-authored-by: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com>
    Co-authored-by: pierre <dommerc.pierre@gmail.com>
    Co-authored-by: Mark Sinclair <mmsinclair@users.noreply.github.com>

commit 5b02801
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Thu May 25 13:54:30 2023 +0200

    nym-cli: support name-service contract (#3404)

    * nym-cli: support name-service contract

    * rustfmt

    * Fix querying names and service-providers

    * Tidy some logging

    * Fix table headers

    * Remove expect from register/delete names

commit 525372d
Author: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com>
Date:   Thu May 25 10:02:27 2023 +0200

    Tmp hack/wasm client persist gateway cfg (#3443)

    * wip

    * semi-hacky way of persisting wasm-client gateway config

    a better way shall be introduced after config refactoring

    * cargo fmt

    * wasm client clippy

    * removed artifacts from other branches

commit e473a05
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Thu May 25 09:29:59 2023 +0200

    Tweak fern logging format to be more similar to pretty_env_logger (#3451)

commit a55d604
Author: Simon Wicky <simon@nymtech.net>
Date:   Tue May 23 16:08:55 2023 +0200

    increase connection buffer size to 2000 (#3439)

commit 5075894
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Tue May 23 15:01:13 2023 +0200

    socks5: abort sending data if the connection is closed (#3365)

    * socks5 inbound: stop reading when closing connection

    * Wait for lane at select top-level

    * Allow closing connection while waiting for lanes to clear

    * Some tidy in inbound.rs

    * Put chained future back inline in the select

    * Remove commented out line

    * Disable the read data branch on is_finished

commit 5c77b48
Merge: 1bec95d 73d5365
Author: Tommy Verrall <60836166+tommyv1987@users.noreply.github.com>
Date:   Tue May 16 15:45:16 2023 +0100

    Merge pull request #3424 from nymtech/feature/nr_coconut

    Link coconut flag with the functionality in the sdk

commit 73d5365
Author: Bogdan-Ștefan Neacșu <bogdan@nymtech.net>
Date:   Tue May 16 15:15:35 2023 +0200

    Link coconut flag with the functionality in the sdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase DEFAULT_MAXIMUM_CONNECTION_BUFFER_SIZE to 2000 to improve reliability
3 participants