Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed nym-node redirects from 308 'Permanent Redirect' to 303: 'See Other' #4572

Merged
merged 1 commit into from
May 7, 2024

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented May 3, 2024

moved nym-node redirects from 308 to 303, applicable for nym-node and no other binaries

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nym-next-explorer ❌ Failed (Inspect) May 3, 2024 2:44pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) May 3, 2024 2:44pm

@tommyv1987 tommyv1987 self-assigned this May 7, 2024
@tommyv1987 tommyv1987 added this to the Nutella milestone May 7, 2024
@tommyv1987
Copy link
Contributor

tommyv1987 commented May 7, 2024

Testing Completion Date:: 07/05/2024

Testing Steps Performed:

  1. build the binary off the bugfix/change-redirects
  2. replace the existing binaries from the machine, stop and start the nym-node-service
  3. perform curl request to the nym-node in question and tail the logs via journalctl
  4. navigate to http://your-nym-node-ip:8080/description in your browser and in your journactl logs if running via system d it will show
May 07 11:14:57 gw.gw.net nym-node[68618]: 2024-05-07T08:14:57.147899Z  INFO nym-node/nym-node-http-api/src/middleware/logging.rs:40: [ip-address:61044 -> 103.231.75.20:8080] GET '/stats': 303 See Other / agent: curl/7.79.1

Validation:

  • [ ✅ ] Test Passed
  • [ ❌ ] Issues Found (Please specify below)

Notes (if any):
[Provide any additional observations or relevant information here.]

Attachments (if applicable):
[Attach any relevant screenshots, logs, or documents.]

@tommyv1987 tommyv1987 merged commit 1136901 into develop May 7, 2024
8 of 9 checks passed
@tommyv1987 tommyv1987 deleted the bugfix/change-redirects branch May 7, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants