Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to sign out #703

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Allow users to sign out #703

merged 2 commits into from
Jul 28, 2021

Conversation

fmtabbara
Copy link
Contributor

No description provided.

@fmtabbara fmtabbara linked an issue Jul 27, 2021 that may be closed by this pull request
@fmtabbara fmtabbara marked this pull request as ready for review July 28, 2021 08:03
@jstuczyn
Copy link
Contributor

Upon yarn build I'm getting the following error:

❯ yarn build
yarn run v1.22.10
$ next build && next export
info  - Using webpack 5. Reason: future.webpack5 option enabled https://nextjs.org/docs/messages/webpack5
Failed to compile.

./components/undelegate/NodeUndelegation.tsx:68:10
Type error: Cannot find name 'undelegationStarted'.

  66 | 
  67 |     // we haven't clicked undelegate button yet
> 68 |     if (!undelegationStarted) {
     |          ^
  69 |       return (
  70 |         <React.Fragment>
  71 |           <NodeTypeChooser nodeType={nodeType} setNodeType={setNodeType} />
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@jstuczyn
Copy link
Contributor

However, it does seem to run under yarn dev and it looks good - fix that compilation error and you're good to merge : )

@@ -104,7 +104,7 @@ const UnbondNode = () => {
}

// we haven't clicked unbond button yet
if (!isLoading) {
if (isLoading === undefined) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this slightly as !isLoading was preventing the <Confirmation /> component from being displayed.

I see why before there was isStarted and isFinished states, but I think it's good to reduce the number of state variables where possible. This way we can achieve the same thing using one state variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the other components with this sort of structure.

@fmtabbara fmtabbara merged commit b949d7b into develop Jul 28, 2021
@fmtabbara fmtabbara deleted the feature/user-sign-out branch July 28, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a wallet user, I would like to be able to log out of the wallet
2 participants