update state management and validation #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
reviewed
Aug 4, 2021
wallet-web/components/bond/utils.ts
Outdated
| } | ||
|
|
||
| if (value.endsWith('.')) { | ||
| value = value.slice(0, value.length - 1) |
There was a problem hiding this comment.
I'm not entirely sure I understand that, why are we removing the last character if it's a .?
jstuczyn
reviewed
Aug 4, 2021
wallet-web/components/bond/utils.ts
Outdated
| } | ||
|
|
||
| export const isValidHostname = (value) => { | ||
| if (typeof value !== 'string') return false |
There was a problem hiding this comment.
We have the niceness of typescript, so change your function definition to export const isValidHostname = (value: string) and the check will be done at compile time : )
jstuczyn
reviewed
Aug 4, 2021
wallet-web/components/bond/utils.ts
Outdated
| return false | ||
| } | ||
|
|
||
| const labels = value.split('.') |
There was a problem hiding this comment.
What if we are faced with an ipv6 address that is separated by : (and has bunch of edge cases)?
Also remember that a hostname like nymtech.net should also be valid
jstuczyn
reviewed
Aug 4, 2021
jstuczyn
approved these changes
Aug 6, 2021
wallet-web/common/helpers.ts
Outdated
| return port >= 1 && port <= 65535 | ||
| } | ||
| export const validateRawPort = (rawPort: number): boolean => | ||
| typeof rawPort === 'number' && |
There was a problem hiding this comment.
the typeof rawPort === 'number' check is redundant, we know for sure it's a number since typescript wouldn't allow anything else here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I appreciate these some of these files might be tricky to compare due to the changes that I've made. I'm happy to talk through the changes if that's preferred.
In a nutshell I have split the original bond form component out into three parts
The biggest change is running validation checks in real-time instead of on submission. The 'Bond' button will be disabled until all fields are valid. Validation functions remain the same apart from the validateHost function which I've updated.
I'll keep this as a draft PR until I've finished testing.