Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/vouchers #837

Merged
merged 63 commits into from
Nov 22, 2021
Merged

Feature/vouchers #837

merged 63 commits into from
Nov 22, 2021

Conversation

aniampio
Copy link
Contributor

  • Migrate the updated coconut library into nym (called nymcoconut)
  • Update the show protocol to include the serial number for the bandwidth credential
  • Create the struct of bandwidth credential with the attribute fields which we should use

aniampio and others added 20 commits October 20, 2021 15:45
@aniampio
[ci skip] Generate TS types
371467c
@aniampio
Run cargo fmt
0eaad03
@aniampio
Merge branch 'feature/vouchers' of https://github.com/nymtech/nym int…
8c23617 
…o feature/vouchers
@aniampio
Merge branch 'develop' into feature/vouchers
4e80c57
@aniampio
Add features flag for coconut
09efb62
@aniampio
Update nymcoconut/src/scheme/mod file
890b0bb
@aniampio
Fix breaking test and remove doctest from nymcoconut
ed2cf1c
@aniampio
Fix unused imports
bd64a29
@aniampio
Rename input variable to be more informative
544355b
@aniampio
Rename input variable to be more informative
842b587
@aniampio
Run cargo fmt
6a3d10b
@aniampio
Rename prove_credential to prove_bandwidth_credential
5bf0a14
@aniampio
Fix warnings from clippy
8250dca
@aniampio
Fix the fields in tauri-client
d1563c0
@aniampio
Run cargo fmt
39af6ab
@aniampio
Update flag #[cfg(feature = coconut)]
bd26bc1
@aniampio
Run cargo fmt
bbd35fe
@aniampio
Fix warnings from clippy
edfd953
@aniampio
Run cargo fmt
22c0669
@aniampio
Fix dead code warning
fba653f
@mmsinclair
Copy link
Contributor

@jstuczyn this is ready for you to look at again 😀

@mmsinclair
Copy link
Contributor

Linked to #2121

neacsu
neacsu approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@neacsu neacsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but if there are some possible out of bounds panics in there, they should be addressed before merge (I haven't seen them)

@mmsinclair
Copy link
Contributor

@aniampio would you mind fixing up the conflicts with develop?

jstuczyn
jstuczyn reviewed Nov 19, 2021
View reviewed changes
Copy link
Contributor

@jstuczyn jstuczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a couple of left over inconsistencies regarding serialization, but I think in general after resolving the pending comments, it could be merged

common/nymcoconut/src/proofs/mod.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/proofs/mod.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/proofs/mod.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/proofs/mod.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/proofs/mod.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/proofs/mod.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/proofs/mod.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/scheme/issuance.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/scheme/issuance.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/scheme/verification.rs Outdated Show resolved Hide resolved
@aniampio aniampio merged commit ab7f24d into develop Nov 22, 2021
@aniampio aniampio deleted the feature/vouchers branch November 22, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neacsu neacsu neacsu approved these changes

@jstuczyn jstuczyn jstuczyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aniampio @mmsinclair @jstuczyn @neacsu