-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rewarding interval updates #880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neacsu
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion: I think you could have targeted for merge the feature/working-rewarded-sets
branch, until that one was merged, so that this PR only showed its own diffs and not those from the other PR
Yep... I definitely should have. My bad! |
durch
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further builds on #864 and thus requires the mentioned PR to be merged first.
This PR introduces mechanism to update
rewarding_interval_starting_block
in the contract state and thus allow for new seed for the PRNG for the selection of the "demanded" set of mixnodes. It does so by introducing two new transactions that explicitly begin and finish mixnode rewarding:ExecuteMsg::BeginMixnodeRewarding
andExecuteMsg::FinishMixnodeRewarding
respectively.ExecuteMsg::BeginMixnodeRewarding
sets newrewarding_interval_starting_block
whileExecuteMsg::FinishMixnodeRewarding
finishes rewarding procedure thus indicating to the validator API that the new set should be determined.Furthermore, no
ExecuteMsg::RewardMixnode
transactions can be sent outside the block defined by the begin and finish transactions. Creation of the block also allowed for easy introduction of protection against rewarding any mixnode more than once during a rewarding interval. We are simply storing a list of which node has been already rewarded during particular interval. Since the rewarding interval is expected to last in order of months, it shouldn't really bloat our storage.Remaining work:
MIXNODE_REWARD_OP_BASE_GAS_LIMIT