Add a Mobile Nav to the Network Explorer #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 9, 2021 15:58
fmtabbara
requested changes
Nov 11, 2021
explorer/src/styles.css
Outdated
| @@ -29,5 +29,12 @@ div div.MuiDataGrid-root .MuiDataGrid-columnHeaderTitleContainer { | |||
| /* Unable to style nested MUI paper within the Drawer | |||
| so styling manually here */ | |||
| div.MuiDrawer-root > .MuiDrawer-paperAnchorLeft { | |||
| background-color: #111826; | |||
| background-color: #242C3D; | |||
There was a problem hiding this comment.
Try paper props on the Drawer - https://mui.com/api/drawer/
There was a problem hiding this comment.
Got some TS issues but actually managed to get around them by using nested sx styling. Happy to re-explore if you think its necessary...
fmtabbara
reviewed
Nov 12, 2021
| } | ||
| if (!nested && isMobile) { | ||
| fixDrawerClose(); | ||
| fixDrawerClose?.(); |
fmtabbara
reviewed
Nov 12, 2021
explorer/src/components/Nav.tsx
Outdated
| open={drawerIsOpen} | ||
| sx={{ | ||
| background: theme.palette.nym.networkExplorer.nav.background, | ||
| // border: '1px solid skyblue', |
fmtabbara
approved these changes
Nov 12, 2021
added 2 commits
November 12, 2021 15:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to implement a responsive full-screen nav for the Network Explorer.
CLOSED:
As a user i expect:
✅ - to NOT see a minimised sidebar, like the one we see on Desktop.
✅ - to see a hamburger in the top right of the screen (AppBar) to prompt user to open menu
BEHAVIOUR:
As a user i expect:
✅ - to see the menu slide out when i tap the Hamburger
✅ - to see the menu slide back when i tap the in-menu collapse icon
OPEN:
As a user i expect:
✅ - to see the expected nav options (Overview, Network Components [mixnodes, gateways, validators] and Nodemap)
✅ - to be able to expand the Network Components to reveal the child options/routes.