Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/faucet page react #911

Merged
merged 13 commits into from Nov 25, 2021
Merged

Feature/faucet page react #911

merged 13 commits into from Nov 25, 2021

Conversation

fmtabbara
Copy link
Contributor

No description provided.

@fmtabbara fmtabbara self-assigned this Nov 20, 2021
tommyv1987
tommyv1987 approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@tommyv1987 tommyv1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with testing. In a separate branch, there are tests for this. But they needn't be merged in for the time being.

@tommyv1987 tommyv1987 marked this pull request as ready for review November 25, 2021 09:59
@tommyv1987 tommyv1987 merged commit b4519cd into develop Nov 25, 2021
@tommyv1987 tommyv1987 deleted the feature/faucet-page-react branch November 25, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyv1987 tommyv1987 tommyv1987 approved these changes

@Aid19801 Aid19801 Awaiting requested review from Aid19801

@futurechimp futurechimp Awaiting requested review from futurechimp

@mfahampshire mfahampshire Awaiting requested review from mfahampshire

@mmsinclair mmsinclair Awaiting requested review from mmsinclair

Assignees

@fmtabbara fmtabbara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmtabbara @tommyv1987