Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom denom balance query #957

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Add custom denom balance query #957

merged 2 commits into from
Dec 16, 2021

Conversation

neacsu
Copy link
Contributor

@neacsu neacsu commented Dec 13, 2021

This is needed so that we can query other denom balances, which is important especially for testing purposes at this moment.

@jstuczyn
Copy link
Contributor

What do you think about doing it the other way around, i.e. have the get_balance take a Denom argument and create something like get_mixnet_balance that would call get_balance with the denom associated with the mixnet contract?

@neacsu
Copy link
Contributor Author

neacsu commented Dec 14, 2021

What do you think about doing it the other way around, i.e. have the get_balance take a Denom argument and create something like get_mixnet_balance that would call get_balance with the denom associated with the mixnet contract?

Sounds good, I've pushed the patch

@neacsu neacsu merged commit 747bf85 into develop Dec 16, 2021
@neacsu neacsu deleted the feature/new_balance_query branch December 16, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants