Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to delete photos #139

Closed
wants to merge 1 commit into from
Closed

Ability to delete photos #139

wants to merge 1 commit into from

Conversation

azonov
Copy link

@azonov azonov commented Jan 20, 2016

No description provided.

@bcapps
Copy link
Contributor

bcapps commented Jan 20, 2016

I will totally defer to my NYT friends as to what to do here, but I will say that the original intent for data changes was to expose the dataSource property and allow clients to create their own data source and add/remove photos to it as needed.

@cdzombak cdzombak self-assigned this Jan 20, 2016
@azonov
Copy link
Author

azonov commented Jan 21, 2016

Yes, but this way, It could make external dependencies (ex. title should be updated with new data) and it is not clear that datasource should implement protocol NYTPhotosViewControllerDataSource. I just do it for myself and share example with community. Thank you for the quick feedback :-).

@cdzombak
Copy link
Contributor

Thank you for the pull request, @azonov. After some internal discussion, though, we're confident we want to handle this capability through a more Cocoa-like data source API; and I've opened #163 to track discussion around that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants