-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding configs and pubsub implementations for GCP plus additional context endpoints and service types #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing graphite host again as deprecated
…ing graphite host again as deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in some new types and tools for working with Google Cloud Platform:
config/GCP
: A helper config for working with Project IDs and contexts across development, App Engine, GCE and GKEconfig/PubSub
: A helper config that is composed of aconfig.GCP
and holds topics and subscription values.pubsub/GCPSubscriber
: A pubsub implementation for subscribing to messages via GCP pubsub.pubsub/GCPPublisher
: A pubsub implementation for publishing messages to GCP pubsub.server/JSONContextEndpoint
: A new JSONEndpoint-like handler to work withcontext.Context
server/JSONContextService
: A newService
implementation composed ofJSONContextEndpoint
s that can register with aSimpleServer
.server/MixedContextService
: A newService
implementation composed ofJSONContextEndpoint
s andContextHandler
s that can register with aSimpleServer
.There is ONE major breaking change in this PR. The
pubsub/Publisher
interface now expects acontext.Context
value passed to thePublish
methods:The context object is currently being used by the GCP implementations, but is ignored by AWS and Kafka.