Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you make the crossorigin attribute dynamic or remove it? #56

Closed
Icoder9699 opened this issue Sep 9, 2024 · 6 comments
Closed

Can you make the crossorigin attribute dynamic or remove it? #56

Icoder9699 opened this issue Sep 9, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Icoder9699
Copy link

Icoder9699 commented Sep 9, 2024

Hi there! Can you please make the crossorigin attribute dynamic or remove it?

@nzbin nzbin added the question Further information is requested label Sep 9, 2024
@nzbin
Copy link
Owner

nzbin commented Sep 9, 2024

May I ask what your problem is? Please check the PR #54 @souramoo

@Icoder9699
Copy link
Author

May I ask what your problem is? Please check the PR #54 @souramoo

When I use it across domains, the image doesn’t show up. Removing the crossorigin attribute from the tag resolved the issue.

For more details: I'm trying to preview an image on a GitHub domain, but the image source is on another domain. In this case, I receive the following error:

Access to image at X from origin 'Y' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

@nzbin
Copy link
Owner

nzbin commented Sep 9, 2024

I'm sorry, I don't find issues on the demo site (https://nzbin.github.io/photoviewer/). It's a GitHub domain and the images are on flickr.

Can you give me a image URL which throwing error?

@Icoder9699
Copy link
Author

Icoder9699 commented Sep 9, 2024

I'm sorry, I don't find issues on the demo site (https://nzbin.github.io/photoviewer/). It's a GitHub domain and the images are on flickr.

Can you give me a image URL which throwing error?

I have sent the link to you via email.

also I temporarily resolved this problem with an older version of the package. in 3.9.1 all is good

@nzbin nzbin added bug Something isn't working and removed question Further information is requested labels Sep 10, 2024
nzbin added a commit that referenced this issue Sep 10, 2024
@nzbin
Copy link
Owner

nzbin commented Sep 10, 2024

Thanks for your advice, new version 3.10.3 has fixed.

@nzbin nzbin closed this as completed Sep 10, 2024
@Icoder9699
Copy link
Author

Thanks for your advice, new version 3.10.3 has fixed.

Thank you for promptly resolving the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants