Remove duplicated example for archive migration #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
emberian
reviewed
Apr 17, 2024
| @@ -86,7 +86,7 @@ The recommended method is to perform migration on your own data to preserve the | |||
|
|
|||
| The correct Devnet/Mainnet database state is crucial for a successful migration. | |||
|
|
|||
| [Missing blocks](/berkeley-upgrade/mainnet-database-maintenance#missing-blocks) is one the most frequent issues when dealing with the Devnet/Mainnet archive. Although this step is optional, it is strongly recommended that you verify the archive condition before you start the migration process. | |||
| [Missing blocks](/berkeley-upgrade/mainnet-database-maintenance#missing-blocks) is one the most frequent issue when dealing with the Devnet/Mainnet archive. Although this step is optional, it is strongly recommended that you verify the archive condition before you start the migration process. | |||
There was a problem hiding this comment.
(i honestly don't know if this is called for or not but i just noticed that Missing could be both a verb and a noun here and that is confusing)
emberian
suggested changes
Apr 17, 2024
| @@ -115,9 +115,15 @@ apt-get install --allow-downgrades -y "mina-archive-migration=$VERSION" | |||
| To get the Docker image: | |||
|
|
|||
| ``` | |||
| docker pull gcr.io/o1labs-192920/mina-archive-migration:3.0.0-rc0 | |||
| docker pull gcr.io/o1labs-192920/mina-archive-migration:3.0.0-rc0-{CODENAME} | |||
There was a problem hiding this comment.
What you mean? should we stick to 3.0.0-rc0 ? i think we need to differentiate between codenames
There was a problem hiding this comment.
I think @amc-ie suggested 3.0.0-release-migration or similar, codename is fine
| @@ -471,156 +477,7 @@ where: | |||
|
|
|||
| ### Example migration steps using Mina Foundation data for Devnet | |||
There was a problem hiding this comment.
Can we confirm that Mina Foundation has custody over the URLs mentioned here?
| @@ -686,6 +543,21 @@ It is worthwhile to perform these last steps as a dry run to make sure all goes | |||
|
|
|||
| Tips to overcome known challenges. | |||
|
|
|||
| #### Berkeley migration app is unstable | |||
There was a problem hiding this comment.
maybe specify the error message in the heading to be specific?
SanabriaRusso
approved these changes
Apr 30, 2024
snaitmouloud-mf
approved these changes
Apr 30, 2024
mitschabaude
approved these changes
May 1, 2024
ghost-not-in-the-shell
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final adjustments for docs