Plonk implementation with updates to Algebra #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits the Plonk implementation for review
added 8 commits
June 3, 2020 19:34
… polynomial computation
imeckler
approved these changes
Jun 10, 2020
|
Hi, is this standard plonk or turboPlonk? Implementing turboplonk in it's most general form requires ripping out the foundations of the circuit builder, I think. |
kobigurk
reviewed
Jun 17, 2020
| @@ -0,0 +1,173 @@ | |||
| /***************************************************************************************************************** | |||
There was a problem hiding this comment.
What about using //! comments so the docs will be nicer?
| let r = | ||
| { | ||
| let mut r = domain.sample_element_outside_domain(&mut OsRng); | ||
| while r.legendre().is_qnr() == false {r = domain.sample_element_outside_domain(&mut OsRng)} |
There was a problem hiding this comment.
It might be better to pass down an implementer of an Rng trait rather than using OsRng directly.
|
|
||
| impl<G: CommitmentCurve> ProverProof<G> | ||
| { | ||
| // This function verifies the batch of zk-proofs |
There was a problem hiding this comment.
/// style comments look nicer in docs
| @@ -38,7 +38,7 @@ type Fr = <Affine as AffineCurve>::ScalarField; | |||
| const MAX_SIZE: usize = 8; | |||
|
|
|||
| #[test] | |||
| fn group_addition_dlog() | |||
| fn dlog_marlin_group_addition() | |||
| { | |||
| let rng = &mut OsRng; | |||
There was a problem hiding this comment.
Many thanks for the suggestions..!
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits the Plonk implementation for review.
This PR is for the review of Plonk implementation that has the following: