Optional feature flags in Pickles.sideLoaded
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
approved these changes
Jun 17, 2024
Comment on lines
+82
to
+88
| Pickles_types.Plonk_types.Features.map feature_flags_ ~f:(function | ||
| | Some true -> | ||
| Pickles_types.Opt.Flag.Yes | ||
| | Some false -> | ||
| Pickles_types.Opt.Flag.No | ||
| | None -> | ||
| Pickles_types.Opt.Flag.Maybe ) |
There was a problem hiding this comment.
nicely done!
btw if you'd want to model Pickles_types.Opt.Flag.t in TS, as an enum without contents it maps to 0 | 1 | 2, where the order is determined by the order that Yes | No | Maybe appear in the enum definition
Trivo25
commented
Jun 17, 2024
| { identifier = Js.to_string rule##.identifier | ||
| ; feature_flags = rule##.featureFlags | ||
| ; feature_flags = |
There was a problem hiding this comment.
I changed the type of the pickles rule here as well to match the rest (less different types we have to consinder in javascript or here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.