Update AffineCurve equal method to account for points at infinity #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inite points on the elliptic curve
…ent points at infinity in elliptic curve
… of PointAtInfinity and FinitePoint
… the other is not
…eFromAffine function
…clude x and y coordinates for consistency
…oordinates for better representation of PointAtInfinity
…o use object destructuring for cleaner code and improve readability
…nity for type consistincey
…ineOnCurve function to destructure parameters and use them directly in calculations
…ntAtInfinity functions as they are not being used in the codebase
ymekuria
changed the title
|
This change causes a bubble-up effect in o1js as well, can you address this in a parent PR into o1js? If this introduces any breaking changes, we should consider targeting V2 if we cannot avoid breaking the API |
I'll link the parent PR in this PR. |
mitschabaude
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue with the the
equal()method inAffineCurve. The method ignores the possibility of either point in the comparison being a point at infinity.Impact
This issue could lead to equality checks that may succeed when they should fail, or vice versa, when the point at infinity is involved.
Changes
PointAtInfinityandFinitePointwere added.GroupAffinewas updated to be a union type of thePointAtInfinityandFinitePoint.equalmethod inCreateCurveAffinewas implemented to correctly handle the cases when either point is at infinity.o1js: o1-labs/o1js#1758