-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move low-level operations to JS #35
Conversation
ocaml/lib/snarky_js_bindings_lib.ml
Outdated
@@ -1227,6 +1239,8 @@ let snarky = | |||
object%js | |||
method add = Snarky.Group.add | |||
|
|||
method ecadd = Snarky.Group.ec_add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL jsoo doesn't like underscores in names; naming it ec_add
can't be resolved for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, I noticed that as well. good way of making you stick to camel case in JS facing APIs :D
ocaml/lib/snarky_js_bindings_lib.ml
Outdated
@@ -1227,6 +1239,8 @@ let snarky = | |||
object%js | |||
method add = Snarky.Group.add | |||
|
|||
method ecadd = Snarky.Group.ec_add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, I noticed that as well. good way of making you stick to camel case in JS facing APIs :D
No description provided.