Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocking SnarkyJS CI tests #50

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Blocking SnarkyJS CI tests #50

merged 3 commits into from
Jun 22, 2023

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Jun 20, 2023 •
edited
Loading

companion of MinaProtocol/mina#13430

changes to the bindings repo:

  • split out a part of the build script for node that only builds the artifacts, and doesn't include the TS build
  • change the layout of files so that it works both when bundling everything with esbuild directly (bypassing TS), and with TS
  • changes the method we use to ensure that TS doesn't try to build the jsoo files, which takes ages

@mitschabaude mitschabaude mentioned this pull request Jun 20, 2023
Merged
@mitschabaude mitschabaude force-pushed the feature/revive-snarkyjs-ci-develop branch from 3d59b0c to 0202843 Compare June 21, 2023 10:11
@mitschabaude mitschabaude marked this pull request as ready for review June 21, 2023 10:23
@mitschabaude mitschabaude changed the title Blocking SnarkyJS CI tests (develop) Blocking SnarkyJS CI tests Jun 21, 2023
@mitschabaude mitschabaude merged commit 29ffb32 into develop Jun 22, 2023
@mitschabaude mitschabaude deleted the feature/revive-snarkyjs-ci-develop branch June 22, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitschabaude @bkase @mrmr1993