Replace this.token with methods on TokenContract
#1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
commented
Feb 20, 2024
Comment on lines
+55
to
+58
| static randomKeypair() { | ||
| let privateKey = PrivateKey.random(); | ||
| return { privateKey, publicKey: privateKey.toPublicKey() }; | ||
| } |
There was a problem hiding this comment.
quality of life improvement, it's annoying to always need two commands to create a keypair
mitschabaude
commented
Feb 20, 2024
There was a problem hiding this comment.
this example was meant as a reproduction at a time where the missing 'access' permission caused a security hole for token contracts, and is long obsolete
mitschabaude
changed the title
this.token with methods on TokenContract
MartinMinkov
approved these changes
Feb 20, 2024
| @@ -71,7 +79,7 @@ class Dex extends SmartContract { | |||
| } | |||
|
|
|||
| @method createAccount() { | |||
| this.token.mint({ address: this.sender, amount: UInt64.from(0) }); | |||
| this.internal.mint({ address: this.sender, amount: UInt64.from(0) }); | |||
There was a problem hiding this comment.
this.internal is a great way to communicate usage within smart contract methods, awesome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1439
Removes
this.tokenfromSmartContractandAccountUpdate, for two reasons:Instead, we reintroduce
mint(),burn()andsend()as helper methods underTokenContract.internal. The intention of this name is to make it clearer that these methods are for use within token contract methods, not from the outside (because they wouldn't be authorized when used from outside)this.token.idis reintroduced asthis.deriveTokenId()on token contracts. The reason to change the API from a property access to a function is that it's actually a function, which computes a hash in the circuit, and it's weird if a property access secretly adds constraints.