Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: safe sender #1464

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Feat: safe sender #1464

merged 8 commits into from
Mar 8, 2024

Conversation

julio4
Copy link
Contributor

@julio4 julio4 commented Feb 27, 2024

Fix #1425

@julio4 julio4 changed the title Feat/safe sender Feat: safe sender Feb 27, 2024
@mitschabaude mitschabaude marked this pull request as ready for review March 7, 2024 11:25
@mitschabaude
Copy link
Member

@julio4 thanks for starting this! I went ahead and finished this PR since some of the decisions whether to use unconstrained vs requiring a signature are a bit subtle, and since landing this has become one of the last dependencies of an upcoming major version upgrade

Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your help, @julio4!

@mitschabaude mitschabaude merged commit 9c2935a into o1-labs:main Mar 8, 2024
13 checks passed
@julio4 julio4 deleted the feat/safe-sender branch April 14, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace this.sender API with something that is secure by default
3 participants