Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Transaction/PendingTransaction behaviors #1480

Merged
merged 12 commits into from
Mar 5, 2024
Merged

Change Transaction/PendingTransaction behaviors #1480

merged 12 commits into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. refactor(transaction): replace sendOrThrowIfError() with send() to si… 

    …mplify error handling
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7cfa3f0 View commit details
    Browse the repository at this point in the history

  2. refactor(transaction): replace waitOrThrowIfError() with wait() and s… 

    …afeWait() to simplify error handling
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9ae5d8a View commit details
    Browse the repository at this point in the history

  3. refactor(transaction-flow.ts): replace waitOrThrowIfError() with wait()

    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9f66687 View commit details
    Browse the repository at this point in the history

  4. refactor(transaction.ts): rename sendSafe method to safeSend for bett… 

    …er readability and consistency with other method names
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    24b2958 View commit details
    Browse the repository at this point in the history

  5. refactor(mina.ts, local-blockchain.ts, transaction.ts): replace isSuc… 

    …cess boolean with status enum for better clarity
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9082494 View commit details
    Browse the repository at this point in the history

  6. feat(transaction-flow.ts): add error handling for failed transactions… 

    … to improve robustness of the transaction flow test
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9ab75fb View commit details
    Browse the repository at this point in the history

  7. docs(transaction.ts): update comments to reflect changes in transacti… 

    …on status handling and error handling
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e2300a4 View commit details
    Browse the repository at this point in the history

  8. refactor(transaction.ts): improve error handling and documentation fo… 

    …r transaction methods

- Refactor send() method to throw an error when transaction submission fails, providing more explicit error handling.
- Update send() method documentation to reflect changes and provide better usage examples.
- Refactor safeSend() method to return a RejectedTransaction when internal errors are detected, providing more detailed feedback.
- Update safeSend() method documentation to reflect changes and provide better usage examples.
- Update wait() method usage examples in IncludedTransaction and RejectedTransaction to demonstrate error handling.
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    8d1554f View commit details
    Browse the repository at this point in the history

  9. feat(CHANGELOG.md): introduce Transaction.safeSend() and PendingTrans… 

    …action.safeWait() methods to handle transaction errors

refactor(CHANGELOG.md): rename Transaction.isSuccess to Transaction.status for better transaction state representation
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4ca39ab View commit details
    Browse the repository at this point in the history

  10. fix(run-live.ts): change condition to check transaction status instea… 

    …d of hash for better transaction tracking

This change will allow us to track the transaction status more accurately and handle it accordingly.
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    145a238 View commit details
    Browse the repository at this point in the history

  11. fix(transaction-flow.ts): return pendingTransaction instead of throwi… 

    …ng error to allow further processing of the transaction status
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    8e920db View commit details
    Browse the repository at this point in the history

  12. docs(CHANGELOG.md): update breaking changes to collapse recent change… 

    …s in transaction parity
    @MartinMinkov
    MartinMinkov committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1ed69eb View commit details
    Browse the repository at this point in the history