Verification key permissions: better-named wrappers #1639
Conversation
| auth: Permissions.proof(), | ||
| txnVersion: TransactionVersion.current(), | ||
| }, | ||
| setVerificationKey: Permissions.VerificationKey.proofUntilHardfork(), |
There was a problem hiding this comment.
I appreciate the creativity to try get it in as a non-breaking change. It looks kind of awkward though to set that particularly permission differently to the rest.
WDYT about deprecating Impossible (so it still works, and the deprecation points to the new one. E.g.)
/**
- @deprecated
Impossiblehas been deprecated and will be removed in a future version. You should use ImpossibleUntilHardFork
*/
Permissons.Impossible
There was a problem hiding this comment.
And add Permissions.ImpossibleUntilHardFork
There was a problem hiding this comment.
It was already looking differently than the rest though!
For any other permission, it's
Permission.impossible()For verification keys, it used to be
{
auth: Permission.impossible(),
txnVersion: Transaction.current()
}so I think it becomes less awkward with this change
There was a problem hiding this comment.
Per slack, we resolved on ImpossibleDuringCurrentVersion as the most accurate and most descriptive (following the existing casing standards of course)
This PR adds new wrappers for verification key permissions, which better convey their meaning.
This was suggested in the original VK permissions RFC: MinaProtocol/mina#13994 (comment)
It also makes setting VK permissions slightly nicer