-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose SHA256 low-level API #1689
Expose SHA256 low-level API #1689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, no major concerns except cleaning up and moving around the otherwise unused constants in the original method
And, feel free to take the honor of adding your changes to the changelog! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Description
partialSHA
anddynamicSHA
as external packages while leveraging the efficiencies of the low-level API.Changes
initial
andintermediate
hashes.message blocks
to prepare it as input to the compression function.