Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix this.sender #1799

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Fix this.sender #1799

merged 6 commits into from
Aug 22, 2024

Conversation

mitschabaude
Copy link
Collaborator

No description provided.

boray
boray approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@boray boray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mitschabaude
Copy link
Collaborator Author

@Trivo25 made more changes, getUnconstrained() without the check would expose people to the same vulnerability

Trivo25
Trivo25 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mitschabaude mitschabaude merged commit d94206d into main Aug 22, 2024
24 checks passed
@mitschabaude mitschabaude deleted the fix/this-sender branch August 22, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boray boray boray approved these changes

@Trivo25 Trivo25 Trivo25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitschabaude @Trivo25 @boray