Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zkApps composability, pt 1: Child parties #285

Merged
merged 7 commits into from
Jul 21, 2022
Merged

zkApps composability, pt 1: Child parties #285

merged 7 commits into from
Jul 21, 2022

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Jul 15, 2022 •
edited
Loading

  • Stacked on top of Support multiple parties (flat) #280
  • Adds the ability to make some parties children of others in the "call forest" structure
  • Adds the hashing logic to compute the public input for a party with children, plus a test which compares this against the Ocaml implementation
  • This doesn't yet deal with calling other zkApps, but is an important step. It also has other use cases -- for example, for creating another party inside a smart contract method which should be constrained by the proof

@mitschabaude mitschabaude changed the title Child parties zkApps composability, pt 1: Child parties Jul 15, 2022
MartinMinkov
MartinMinkov approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@MartinMinkov MartinMinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can't wait to have this, at the moment I am hardcoding the callDepth for token transfers so this API will be great :D

@mitschabaude mitschabaude mentioned this pull request Jul 20, 2022
Merged
Base automatically changed from feature/many-parties to main July 21, 2022 18:21
@mitschabaude mitschabaude merged commit 8c7880b into main Jul 21, 2022
@mitschabaude mitschabaude deleted the feature/child-parties branch July 21, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

@MartinMinkov MartinMinkov MartinMinkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitschabaude @bkase @MartinMinkov