Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lte for UInt64, UInt32, and tests #307

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Fix lte for UInt64, UInt32, and tests #307

merged 1 commit into from
Jul 27, 2022

Conversation

MartinMinkov
Copy link
Contributor

Fixes #174 and related tests

Updated unit tests and ran successfully

mitschabaude
mitschabaude approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Simple and effective 💯

@MartinMinkov MartinMinkov merged commit 971dfd3 into main Jul 27, 2022
@MartinMinkov MartinMinkov deleted the fix/rangeCheckHelper branch July 27, 2022 16:12
@MartinMinkov MartinMinkov mentioned this pull request Jul 27, 2022
Closed
@mitschabaude mitschabaude mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Failures (Int.ts) - rangeCheckHelper
2 participants
@MartinMinkov @mitschabaude