Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpose party leaf types #311

Merged
merged 13 commits into from
Aug 1, 2022
Merged

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Jul 30, 2022

Stacked on #310

Code cleanup PR which mostly affects parties-leaves.ts. Instead of having multiple "modules" like ToFields, ToJson etc, each of which has conversion functions for the core party types like Field, Bool, PublicKey, etc, we "transpose" the code structure, so that we have multiple types, each of which implements methods like toFields, toJson etc. This reduces lots of redundant code since we already implement most of these methods on most of these types, elsewhere.

As a side effect, this PR has to implement the new toInput method (introduced by #310) on CircuitValue, Field, Bool and on the type returned by circuitValue()

Base automatically changed from feature/compatible-hashing to main August 1, 2022 21:12
@mitschabaude mitschabaude merged commit cce3fee into main Aug 1, 2022
@mitschabaude mitschabaude deleted the feature/transpose-party-leaf-types branch August 1, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants