Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gte/assertGte to UInt types #349

Merged
merged 1 commit into from
Aug 12, 2022
Merged

add gte/assertGte to UInt types #349

merged 1 commit into from
Aug 12, 2022

Conversation

Trivo25
Copy link
Member

@Trivo25 Trivo25 commented Aug 12, 2022 •
edited

Adds x.gte(y) and x.assertGte(y) to UInt64 and UInt32 as a small quality of life change

Tests have been extended as well

closes #347

mitschabaude
mitschabaude approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of tests, nice!

@Trivo25 Trivo25 merged commit 3c3a5a4 into main Aug 12, 2022
@Trivo25 Trivo25 deleted the feature/add-missing-gte-types branch August 12, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add gte to UInt types
2 participants
@Trivo25 @mitschabaude