Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enableProofs #462

Merged
merged 1 commit into from
Sep 29, 2022
Merged

add enableProofs #462

merged 1 commit into from
Sep 29, 2022

Conversation

Trivo25
Copy link
Member

@Trivo25 Trivo25 commented Sep 29, 2022 •
edited
Loading

Missing piece to #150

  • if enableProofs == false,
    • tx.prove() will be "skipped" and a dummy proof will be inserted instead, this will help us not having to use tx.sign() every time
    • proofs wont be verified

companion of MinaProtocol/mina#11943

@Trivo25 Trivo25 mentioned this pull request Sep 29, 2022
Merged
mitschabaude
mitschabaude approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Trivo25 Trivo25 merged commit bcf3e8c into main Sep 29, 2022
@Trivo25 Trivo25 deleted the disable-proving branch September 29, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trivo25 @mitschabaude