Add access permission to accounts #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..and manually confirm that the arbitrary token interaction example doesn't work anymore
mrmr1993
approved these changes
Oct 20, 2022
bkase
reviewed
Oct 23, 2022
| * all other permissions combined. For normal accounts it can safely be set to `none`, but for token contracts this has to be more restrictive, to | ||
| * prevent unauthorized token interactions -- for example, it could be `proofOrSignature`. | ||
| */ | ||
| access: Permission; |
There was a problem hiding this comment.
Any thoughts on how we default this to non-none somehow when working with tokens? Happy path needs to be the secure one
There was a problem hiding this comment.
We could export a TokenContract which is SmartContract but with defaults changed to be secure for token contracts
And have all our examples and docs for tokens point to this
|
Not ready for merge yet! Still has tests failing, revealed by this manual run: https://github.com/o1-labs/snarkyjs/actions/runs/3524467107/jobs/5909909541 |
…add-access-permission
…implicit-account-creation-fee
|
now that the Mina companion is merged, this needs updated bindings from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accesspermission to accounts MinaProtocol/mina#12003accesspermission of "Either" (proof of signature) for all example token contracts