Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes static one/zero/-1 from Field #524

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Removes static one/zero/-1 from Field #524

merged 2 commits into from
Nov 1, 2022

Conversation

bkase
Copy link
Member

@bkase bkase commented Nov 1, 2022

Part of #511

@bkase
Copy link
Member Author

bkase commented Nov 1, 2022

How do I rebuild the reference docs for the docs2 site? @MartinMinkov

@MartinMinkov
Copy link
Contributor

How do I rebuild the reference docs for the docs2 site? @MartinMinkov

I don't think we need to rebuild the reference docs quite yet since we are not publishing a new version on NPM. If we rebuild the docs for these changes, it won't reflect what users are actually downloading off NPM, so we should wait until there's a new SnarkyJS version :D

Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately looks good to me!
but better to deprecate instead of removing the props

@bkase bkase merged commit 4c9316b into main Nov 1, 2022
@bkase bkase deleted the field-static-remove branch November 1, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants