Replace .sign() with .requireSignature() #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #441
This PR deprecates
.sign()on SmartContract as well as AccountUpdate in favor of.requireSignature().requireSignature()is different in that it doesn't take an optional private key as input. The idea is to move to a default flow where all private keys are passed intotx.sign([...])after constructing the tx. This is already possible withthis.sign()but we now want to make this the only supported flow of signing transactions. The reason is that only with this flow, it's possible to have the tx signed by a wallet, and it's confusing to have two different ways of doing it.We also add doc-comments to sign / requireSignature!