Remove timestamp field in zkapp_precondition #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but we shouldn't merge yet - should set up and run a CI workflow for this branch first |
|
@ghost-not-in-the-shell to make the checks pass, you need to update the OCaml bindings of snarkyjs. this is done by running the following from the Mina repo: ./scripts/update-snarkyjs-bindings.shand committing the result here |
| @@ -395,7 +395,7 @@ function LocalBlockchain({ | |||
| } | |||
| events[addr][tokenId].push({ | |||
| events: p.body.events, | |||
| slot: networkState.globalSlotSinceHardFork.toString(), | |||
| slot: networkState.globalSlotSinceGenesis.toString(), | |||
There was a problem hiding this comment.
@mitschabaude Since I removed globalSlotSinceHardFork, I replaced this with globalSlotSinceGenesis, would that be okay?
added 7 commits
November 22, 2022 01:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
timestampand alsoglobalSlotSinceHardForkfield inzkapp_precondition