-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account deriver #741
Merged
Merged
Account deriver #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..and manually confirm that the arbitrary token interaction example doesn't work anymore
…add-access-permission
…into remove-timestamp
Merge main into berkeley
Fix v1 transaction hashes
Trivo25
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just some minor questions :)
Oh, and it would be good to briefly mention that the set of test accounts now have other pre-defined permissions (in case someone wonders why their tests broke) #638 |
This was referenced Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #725
FetchedAccount
type which reflects the structure of the account query result.src/lib/mina/account.ts
which contains all account types, plus logic to convert fromFetchedAccount
toAccount
.FetchedAccount
were added to be able to fill them in when converting. Incidentally, this means that theprovedState
precondition is now supported (that was one of the missing fields)