Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account deriver #741

Merged
merged 188 commits into from
Feb 23, 2023
Merged

Account deriver #741

merged 188 commits into from
Feb 23, 2023

Conversation

mitschabaude
Copy link
Collaborator

@mitschabaude mitschabaude commented Feb 21, 2023

closes #725

  • this replaces the existing main account type in snarkyjs with one that is auto-generated from ocaml. it does not replace the FetchedAccount type which reflects the structure of the account query result.
  • new file src/lib/mina/account.ts which contains all account types, plus logic to convert from FetchedAccount to Account.
  • Some missing fields in FetchedAccount were added to be able to fill them in when converting. Incidentally, this means that the provedState precondition is now supported (that was one of the missing fields)
  • Because it was a quick fix, also resolves Make test accounts have normal permissions #638 (see Mina PR)

mitschabaude and others added 30 commits May 4, 2022 21:27
..and manually confirm that the arbitrary token interaction example doesn't work anymore
@mitschabaude mitschabaude marked this pull request as ready for review February 22, 2023 12:24
Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just some minor questions :)

src/examples/simple_zkapp.ts Show resolved Hide resolved
src/lib/fetch.ts Outdated Show resolved Hide resolved
src/provable/gen/transaction-bigint.ts Show resolved Hide resolved
src/provable/gen/transaction.ts Show resolved Hide resolved
@Trivo25
Copy link
Member

Trivo25 commented Feb 22, 2023

Oh, and it would be good to briefly mention that the set of test accounts now have other pre-defined permissions (in case someone wonders why their tests broke) #638

@mitschabaude mitschabaude merged commit 421e118 into main Feb 23, 2023
@mitschabaude mitschabaude deleted the feature/account-deriver branch February 23, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants