Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make unit test script portable #750

Merged
merged 1 commit into from
Feb 26, 2023
Merged

make unit test script portable #750

merged 1 commit into from
Feb 26, 2023

Conversation

mimoo
Copy link
Contributor

@mimoo mimoo commented Feb 25, 2023

this was not working on mac previously

@mimoo
Copy link
Contributor Author

mimoo commented Feb 25, 2023

mmm, I still get an error which seems weird:

/Users/david/Work/mina/src/lib/snarky_js_bindings/snarkyjs/dist/node/_node_bindings/snarky_js_node.bc.cjs:7508
         throw err;
         ^

Error: Cannot prove execution of myMethod(), no prover found. Try calling `await MyContract.compile()` first, this will cache provers in the background.
    at addProof (file:///Users/david/Work/mina/src/lib/snarky_js_bindings/snarkyjs/dist/node/lib/account_update.js:1220:19)
    at addMissingProofs (file:///Users/david/Work/mina/src/lib/snarky_js_bindings/snarkyjs/dist/node/lib/account_update.js:1253:52)
    at Object.prove (file:///Users/david/Work/mina/src/lib/snarky_js_bindings/snarkyjs/dist/node/lib/mina.js:142:50)
    at file:///Users/david/Work/mina/src/lib/snarky_js_bindings/snarkyjs/dist/node/lib/circuit_value.unit-test.js:139:10

@mimoo
Copy link
Contributor Author

mimoo commented Feb 25, 2023

after running npm i && num run build all the tests in dist have disappeared :D confused

@mitschabaude
Copy link
Contributor

after running npm i && num run build all the tests in dist have disappeared :D confused

That's expected, npm run build cleans up the folder and doesn't build the unit tests. To build & run one test we have
./run path/to/test

@mimoo
Copy link
Contributor Author

mimoo commented Feb 25, 2023

npm run build cleans up the folder and doesn't build the unit tests

I was wondering how the tests are there in my checkout then, maybe make snarkyjs places them there?

(also not sure why CI is not passing)

@Trivo25
Copy link
Member

Trivo25 commented Feb 25, 2023

something is wrong with the Berkeley live integration test - not your fault :D

Copy link
Contributor

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works. Thanks @mimoo!

@mitschabaude mitschabaude merged commit e10a273 into main Feb 26, 2023
@mitschabaude mitschabaude deleted the mimoo/portable branch February 26, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants