-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename all references of actionsHash to actionState #833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we plan on releasing a minor version before the next big one, if that's the case imo we should wait with merging cc @jasongitmail
edit: ah nvm, I dont think this touches any public APIs 👍
The intention behind this PR was to be consistent with this PR too :P #828 It renames the input parameters fromStateHash and endStateHash to fromStateAction and endStateAction. As a follow-up, we've also renamed actionHash to actionState for the reducer. This update does affect the public API, but no worries - the new release is already planned as a breaking change due to the |
reopened this because it isn't merged yet :D |
Summary
This pull request introduces breaking changes to improve naming consistency with the Mina protocol implementation. We've renamed all references of
actionsHash
toactionState
. These changes affect variables, function parameters, and object keys throughout the codebase.🔗 Associated changes to the docs are located here: o1-labs/docs2#345