Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all references of actionsHash to actionState #833

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

MartinMinkov
Copy link
Contributor

@MartinMinkov MartinMinkov commented Apr 5, 2023

Summary

This pull request introduces breaking changes to improve naming consistency with the Mina protocol implementation. We've renamed all references of actionsHash to actionState. These changes affect variables, function parameters, and object keys throughout the codebase.

🔗 Associated changes to the docs are located here: o1-labs/docs2#345

Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we plan on releasing a minor version before the next big one, if that's the case imo we should wait with merging cc @jasongitmail

edit: ah nvm, I dont think this touches any public APIs 👍

@MartinMinkov
Copy link
Contributor Author

I wonder if we plan on releasing a minor version before the next big one, if that's the case imo we should wait with merging cc @jasongitmail
edit: ah nvm, I dont think this touches any public APIs +1

The intention behind this PR was to be consistent with this PR too :P #828

It renames the input parameters fromStateHash and endStateHash to fromStateAction and endStateAction. As a follow-up, we've also renamed actionHash to actionState for the reducer.

This update does affect the public API, but no worries - the new release is already planned as a breaking change due to the getActions renaming.

@nicc nicc added the product-eng For tracking our team's issues label Apr 11, 2023
@nicc nicc closed this Apr 25, 2023
@mitschabaude mitschabaude reopened this Apr 25, 2023
@mitschabaude
Copy link
Collaborator

reopened this because it isn't merged yet :D

@MartinMinkov MartinMinkov merged commit 9b84df9 into main Apr 26, 2023
@MartinMinkov MartinMinkov deleted the feat/update-actionhash-actionstate branch April 26, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product-eng For tracking our team's issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants