Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public output for ZkProgram #874

Merged
merged 19 commits into from
May 5, 2023
Merged

Conversation

mitschabaude
Copy link
Collaborator

@mitschabaude mitschabaude commented Apr 27, 2023

closes #523
bindings companion: o1-labs/o1js-bindings#4

  • adapt the Pickles interface in snarky.d.ts to take both public input + output, instead of just input, to follow the changes in Public output for ZkProgram o1js-bindings#4
  • propagate these changes to the Proof class, which is now Proof<PublicInput, PublicOutput>
  • also propagate the changes to the ZkProgram API
  • do not change SmartContract, which has the public output fixed to undefined

testing:

docs:

Base automatically changed from feature/move-bindings-2 to main May 3, 2023 10:11
@mitschabaude mitschabaude marked this pull request as ready for review May 5, 2023 08:44
Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@mitschabaude mitschabaude merged commit a519dab into main May 5, 2023
@mitschabaude mitschabaude deleted the feature/zkprogram-return-new branch May 5, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZkProgram methods return their return values rather than require them as arguments
2 participants