[EASY] IVC: add the challenges required by the block selection and expose the IVC challenges count #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing is useful for external users. It will be used in the ADD example.
dannywillems
force-pushed
the
dw/add-chals-block-selector
branch
from
17dbb76
to
a97b88e
Compare
dannywillems
changed the title
dannywillems
force-pushed
the
dw/add-chals-block-selector
branch
from
a97b88e
to
a886cca
Compare
dannywillems
force-pushed
the
dw/add-chals-block-selector
branch
from
a886cca
to
0d81729
Compare
volhovm
approved these changes
Jun 24, 2024
| /// for now. | ||
| /// We also add the number of "blocks" in the IVC circuit as there will be | ||
| /// [N_BLOCKS] alphas required to aggregate all blocks on each row. | ||
| pub const IVC_NB_CHALLENGES: usize = IVC_POSEIDON_NB_CONSTRAINTS + N_BLOCKS; |
There was a problem hiding this comment.
Right now this will not be enough: folding needs the /sum/ of constraints, not the max(block_constraints) + common_constraints. To be optimised in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is required to have a correctly shaped/sound IVC circuit.