Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for zkVM CLI/Host integration #34

Closed
wants to merge 1 commit into from

Conversation

rbonichon
Copy link

No description provided.


``` {#preimage_response_format .text}
+------------+--------------------+
| length <8> | pre-image <length> |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is here pre-image the actual data? or the address in memory where it was mapped?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the data indeed.

Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could benefit from more detail, but what's here LGTM so far.

@@ -0,0 +1,194 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to be a markdown document.

@joseandro
Copy link
Contributor

Closing this as we will defer to using our code documentation mirroring 1:1 the OP stack. cc @rbonichon @mrmr1993

@joseandro joseandro closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants