Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

o1js reflected changes. #595

Merged
merged 8 commits into from
Mar 6, 2024
Merged

o1js reflected changes. #595

merged 8 commits into from
Mar 6, 2024

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Feb 23, 2024

[WARNING]:

@shimkiv shimkiv self-assigned this Feb 23, 2024
@shimkiv shimkiv changed the title o1js#1422 reflected changes. [WARNING inside] o1js#1422 reflected changes. Feb 23, 2024
@shimkiv
Copy link
Member Author

shimkiv commented Feb 23, 2024

Tests passed only because the way template projects are handled:

zkapp-cli/src/lib/project.js

Line 165 in 8b1c4fc

const src = 'github:o1-labs/zkapp-cli#main';

MartinMinkov
MartinMinkov approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@MartinMinkov MartinMinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! I forgot the hash was used in the CLI 😅. Thanks for picking that up so quick!

@shimkiv shimkiv changed the title [WARNING inside] o1js#1422 reflected changes. [DO NOT MERGE] o1js#1422 reflected changes. Feb 23, 2024
ymekuria
ymekuria approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@ymekuria ymekuria left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating this!

@shimkiv shimkiv mentioned this pull request Mar 5, 2024
Closed
@shimkiv shimkiv changed the title [DO NOT MERGE] o1js#1422 reflected changes. o1js reflected changes. Mar 6, 2024
@shimkiv shimkiv merged commit 80e1cb5 into main Mar 6, 2024
12 checks passed
@shimkiv shimkiv deleted the fix/parity branch March 6, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMinkov MartinMinkov MartinMinkov approved these changes

@ymekuria ymekuria ymekuria approved these changes

Assignees

@shimkiv shimkiv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shimkiv @ymekuria @MartinMinkov