Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to query that works across eS 5 and ES 6 boundary #3

Merged
merged 4 commits into from
Nov 1, 2019

Conversation

epugh
Copy link
Member

@epugh epugh commented Aug 8, 2019

Description

Change to a query type that runs across ES 5 and 6

Motivation and Context

This is to deal with the issue raised by #2

How Has This Been Tested?

Created new ES 5, 6, and 7 deploys with the SAME dataset and then manually tested:
https://github.com/o19s/quepid/wiki/Troubleshooting-Elasticsearch-and-Quepid#demo-elasticsearch-indexes-with-the-tmdb-dataset

Screenshots or GIFs (if appropriate):

{
  "query": {
   "query_string": {
      "query": "#$query##"
   }
  }
}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh closed this in 311807c Sep 13, 2019
epugh added a commit that referenced this pull request Sep 13, 2019
base64 encode document ids that contain a period.  fixes #3
@epugh epugh reopened this Oct 31, 2019
@epugh
Copy link
Member Author

epugh commented Oct 31, 2019

Okay, in poking around, I've learned that this code never got merged. I've retested this template, and it does work, so need to merge.

@epugh epugh merged commit 24b1f16 into master Nov 1, 2019
@epugh
Copy link
Member Author

epugh commented Nov 1, 2019

just retested

@nathancday nathancday deleted the default-es-query-across-es5-es6 branch March 13, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant