base64 encode document ids that contain a period. fixes #3 #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid freaking out the Rails API by base 64 encoding any documents id's that have a period in it.
Description
Tagging onto the existing logic for base64 encoding documents whose id's look like URL's, with
http
, we also look for.
in the docId.Motivation and Context
Fixes #5
How Has This Been Tested?
Wrote a test for the JavaScript, then manually tested.
Screenshots or GIFs (if appropriate):
Types of changes
Checklist: