Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base64 encode document ids that contain a period. fixes #3 #6

Merged
merged 7 commits into from
Sep 13, 2019

Conversation

epugh
Copy link
Member

@epugh epugh commented Sep 3, 2019

Avoid freaking out the Rails API by base 64 encoding any documents id's that have a period in it.

Description

Tagging onto the existing logic for base64 encoding documents whose id's look like URL's, with http, we also look for . in the docId.

Motivation and Context

Fixes #5

How Has This Been Tested?

Wrote a test for the JavaScript, then manually tested.

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh
Copy link
Member Author

epugh commented Sep 3, 2019

Sigh, found that I need to update the API side as well...

@epugh epugh merged commit 4d7f5c5 into master Sep 13, 2019
@epugh
Copy link
Member Author

epugh commented Sep 13, 2019

Okay, talked to @ychaker last week, it's sat and marinated for a while. Time to merge!

@nathancday nathancday deleted the bugfix-3-rating-docs branch March 13, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rating documents whose ID contains a period rejected by Quepid API!
1 participant