Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): Add syntax highlighting to YAML block #1172

Merged
merged 1 commit into from Sep 18, 2023

Conversation

spenserblack
Copy link
Collaborator

This makes it a bit easier to read the example YAML, and separate the commented-out instructions from the relevant code IMO.

Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spenserblack

@spenserblack
Copy link
Collaborator Author

Looks like the required checks won't run because **.md is an ignored pattern 😆 @o2sh I think only admins can force a merge without required checks running.

IIRC GitHub is considering allowing rulesets to ignore patterns for exactly this issue, but I don't think it's been deployed yet.

@o2sh o2sh merged commit 2a72635 into o2sh:main Sep 18, 2023
1 check passed
@spenserblack spenserblack deleted the chore/syntax-highlighting branch September 18, 2023 19:40
@o2sh o2sh added the doc label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants