Right align authorship percentages #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenserblack
approved these changes
Nov 10, 2023
lukehsiao
commented
Nov 10, 2023
lukehsiao
commented
Nov 10, 2023
o2sh
reviewed
Nov 10, 2023
o2sh
reviewed
Nov 12, 2023
This patch right-aligns the percentages for authorship to make them
easier to visually compare.
Before:
Authors: 53% Ossama Hjaji 1212
21% dependabot[bot] 485
4% Spenser Black 88
After:
Authors: 53% Ossama Hjaji 1212
21% dependabot[bot] 485
4% Spenser Black 88
Tested: Cargo test all passes. Also added a new test that checks
alignment in a simple case, and tested that the output looks as
intended locally.
Signed-off-by: Luke Hsiao <luke.hsiao@numbersstation.ai>
spenserblack
approved these changes
Nov 13, 2023
|
Thanks for the detailed and thoughtful reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch right-aligns the percentages for authorship to make them
easier to visually compare.
Before:
After:
Tested: Cargo test all passes. Also added a new test that checks
alignment in a simple case, and tested that the output looks as
intended locally.