Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gitoxide to v0.21.1 #752

Merged
merged 4 commits into from
Aug 24, 2022
Merged

update gitoxide to v0.21.1 #752

merged 4 commits into from
Aug 24, 2022

Conversation

Byron
Copy link
Collaborator

@Byron Byron commented Aug 23, 2022

The most notable improvement is its ability to open submodule
repositories, thus increasing the amount of repositories onefetch
can handle.

The most notable improvement is its ability to open submodule
repositories, thus increasing the amount of repositories onefetch
can handle.
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #752 (5179dce) into main (2dc2e63) will increase coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   37.40%   37.54%   +0.13%     
==========================================
  Files          19       19              
  Lines        1342     1337       -5     
==========================================
  Hits          502      502              
+ Misses        840      835       -5     
Impacted Files Coverage Δ
src/info/mod.rs 0.00% <ø> (ø)
src/info/repo.rs 16.95% <0.00%> (+0.29%) ⬆️
src/main.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This fixes an issue with submodules not being handled correctly if `.`
was passed as input for discovery.
Instead, postpone the work-tree check to when it is needed and exit
with the same message.
@Byron
Copy link
Collaborator Author

Byron commented Aug 23, 2022

It appears that CI is testing more environments now and the failure is legitimate. It tries to compile SHA-1 assembly on MSVC which is known to fail. However, gitoxide tries to not turn it on.

That seems to not work though and it's not the first time. One could experiment with other ways of turning it off on MSVC potentially from the manifest of onefetch, but ideally that's entirely handled by gitoxide. Lastly, if nothing else works, ASM for SHA-1 can be disabled entirely as I don't think hashing performance is important for onefetch's workload.

Thanks for your suggestions.

Byron added a commit to GitoxideLabs/gitoxide that referenced this pull request Aug 23, 2022
That way one has an angle on compile failures in client libraries,
see o2sh/onefetch#752 for motivation.
@o2sh
Copy link
Owner

o2sh commented Aug 24, 2022

Thanks a lot @Byron
Sorry for that painful update 😅

@o2sh o2sh merged commit f52fed6 into o2sh:main Aug 24, 2022
@Byron Byron deleted the gitoxide-update branch August 25, 2022 01:06
@Byron
Copy link
Collaborator Author

Byron commented Aug 25, 2022

Thanks a lot @Byron
Sorry for that painful update 😅

I am glad these issues trigger here so we can sort them out (like I thought I did a while ago but something clearly isn't working). @davidkna posted a PR today which might also affect how sha1-asm builds are handled and also created a fix upstream. To be continued….

@o2sh
Copy link
Owner

o2sh commented Aug 25, 2022

That's great news, keep us posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants