-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gitoxide to v0.21.1 #752
Conversation
The most notable improvement is its ability to open submodule repositories, thus increasing the amount of repositories onefetch can handle.
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
==========================================
+ Coverage 37.40% 37.54% +0.13%
==========================================
Files 19 19
Lines 1342 1337 -5
==========================================
Hits 502 502
+ Misses 840 835 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This fixes an issue with submodules not being handled correctly if `.` was passed as input for discovery.
Instead, postpone the work-tree check to when it is needed and exit with the same message.
It appears that CI is testing more environments now and the failure is legitimate. It tries to compile SHA-1 assembly on MSVC which is known to fail. However, gitoxide tries to not turn it on. That seems to not work though and it's not the first time. One could experiment with other ways of turning it off on MSVC potentially from the manifest of Thanks for your suggestions. |
That way one has an angle on compile failures in client libraries, see o2sh/onefetch#752 for motivation.
Thanks a lot @Byron |
I am glad these issues trigger here so we can sort them out (like I thought I did a while ago but something clearly isn't working). @davidkna posted a PR today which might also affect how sha1-asm builds are handled and also created a fix upstream. To be continued…. |
That's great news, keep us posted. |
The most notable improvement is its ability to open submodule
repositories, thus increasing the amount of repositories onefetch
can handle.