restrict sha1 asm to supported archs#501
Merged
Sebastian Thiel (Byron) merged 1 commit intoGitoxideLabs:mainfrom Aug 25, 2022
Merged
restrict sha1 asm to supported archs#501Sebastian Thiel (Byron) merged 1 commit intoGitoxideLabs:mainfrom
sha1 asm to supported archs#501Sebastian Thiel (Byron) merged 1 commit intoGitoxideLabs:mainfrom
Conversation
Member
|
Thanks a lot! I did have some trouble with this in Do I assume correctly that you validated it? CI here isn't testing ARM32. The name-change is much appreciated, too, I'd probably have stopped to receive updates because of it. In any case, I am merging the change now in the hope it helps, please let me know if you need a new release after validating the change is effective. Thanks a lot. |
Contributor
Author
I only validated compilation via cross. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It only compiles on aarch64, x86 and x86_64 (I also made an upstream PR, but I'm not sure how receptive they will be to that considering they still haven't disabled MSVC). I also switched the cargo files to use the new crate name
sha1.Ok for Byron review the PR on video?
If I think the review will be helpful for the community, then I might record and publish a video.