Skip to content

Conversation

spenserblack
Copy link
Collaborator

@spenserblack spenserblack commented Oct 13, 2019

Fixes #69
Might also help with #33 🤔

The formatting of these changes are kind of ugly, please let me know if you want any changes to code format 😃.

onefetch -h

help
There is a 0 option, but it's invisible due to black background

onefetch -c 0 3

0-3

@o2sh
Copy link
Owner

o2sh commented Oct 13, 2019

This is great @spenserblack
I think it solves #33 too.

You just need add a visual marker, something like (or else if you have a better idea) -->

DeepinScreenshot_select-area_20191013213518

Looking forward to merge your PR

@spenserblack
Copy link
Collaborator Author

Just the 8 colors (Black - White), or also the bright versions of those colors?

@o2sh
Copy link
Owner

o2sh commented Oct 13, 2019

I would say the more better as long as it doesn't take too much space...

@spenserblack
Copy link
Collaborator Author

How does this look?
screen

@o2sh
Copy link
Owner

o2sh commented Oct 13, 2019

LGTM 🥇

@o2sh o2sh merged commit 67616ea into o2sh:master Oct 13, 2019
@spenserblack spenserblack deleted the select-colors branch October 14, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Custom colors via flag
2 participants