adding language ABNF #811
Merged
adding language ABNF #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenserblack
requested changes
Oct 8, 2022
There was a problem hiding this comment.
Thank you!
I personally like how this looks on a dark terminal, but I think the majority prefer more contrast. Especially since this logo has many "thin" characters. It's a bit hard to see in the preview.
#888888 is roughly the halfway point between completely light (#FFFFFF) and completely dark (#000000). #7F7F7F is more accurately halfway, but not as pretty of a number 😆
o2sh
reviewed
Oct 8, 2022
Co-authored-by: Spenser Black <spenserblack01@gmail.com>
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
|
Hi @o2sh and @spenserblack, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image for this is inspired by the railroad diagram that are used with syntax diagrams that ABNF usually represent.
I couldn't find a color for chip on the linguist site.