Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up greeter and fix repository detection mechanism in wiki #927

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

quazar-omega
Copy link
Contributor

Followed some better practices for the code as well as fixed up some issues:

  • getting in, out and back in the repository wouldn't trigger the greeter
  • if you opened a terminal/shell directly in a directory within the repository wouldn't trigger the greeter

These could actually be preferable behaviors for some, but I figured it'd be better to put the features in, if you want I can make it so that certain behaviors are disabled depending on respective variables

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if the automated update works 🤞

@quazar-omega
Copy link
Contributor Author

Hopefully, on my fork it failed, but I think it might just be a misconfiguration on my end

@spenserblack
Copy link
Collaborator

on my fork it failed

Looks like you don't have wikis enabled. Also, you may need to set up a PAT to work on your fork.

The action is definitely in need of some more informative error messages! 😆

.github/wiki/Getting-Started.md Outdated Show resolved Hide resolved
.github/wiki/Getting-Started.md Outdated Show resolved Hide resolved
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
@quazar-omega
Copy link
Contributor Author

Looks like you don't have wikis enabled. Also, you may need to set up a PAT to work on your fork.

Thanks, I'll see if I can fix that!
What is PAT by the way? I'm not familiar with GitHub actions

The action is definitely in need of some more informative error messages! 😆

My noob self would appreciate that quite a bit lol

@spenserblack
Copy link
Collaborator

spenserblack commented Jan 11, 2023

What is PAT by the way?

Personal Access Token. It would get included in your GitHub Actions secrets in your repo's settings.

I need to experiment more with what access scope is necessary to use this action, and document those requirements, but it seems like a classic token with full repo access is plenty. For security purposes, this should be scaled back to the bare essentials, though. I don't want to document nor recommend anything more than the bare minimum required access 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants