Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added acceleration to vehicle dynamics. #102

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Added acceleration to vehicle dynamics. #102

merged 1 commit into from
Feb 9, 2023

Conversation

michalpelka
Copy link
Contributor

Signed-off-by: Michał Pełka michal.pelka@robotec.ai

@michalpelka michalpelka force-pushed the mp/vehicle_dynamic_acceleration branch from fc410f6 to cb64018 Compare January 31, 2023 13:35
@michalpelka michalpelka force-pushed the mp/vehicle_dynamic_acceleration branch from cb64018 to 553d9a4 Compare February 1, 2023 15:09
@michalpelka michalpelka marked this pull request as ready for review February 1, 2023 15:12
@michalpelka michalpelka requested review from a team as code owners February 1, 2023 15:12
hultonha
hultonha approved these changes Feb 1, 2023
View reviewed changes
Copy link

@hultonha hultonha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me I just have a few minor suggestions 👍

Gems/ROS2/Code/Source/VehicleDynamics/DriveModels/SkidSteeringDriveModel.cpp Outdated Show resolved Hide resolved
Gems/ROS2/Code/Source/VehicleDynamics/DriveModels/SkidSteeringDriveModel.cpp Outdated Show resolved Hide resolved
Gems/ROS2/Code/Source/VehicleDynamics/DriveModels/SkidSteeringDriveModel.h Outdated Show resolved Hide resolved
Gems/ROS2/Code/Source/VehicleDynamics/Utilities.cpp Outdated Show resolved Hide resolved
Gems/ROS2/Code/Source/VehicleDynamics/Utilities.cpp Outdated Show resolved Hide resolved
Gems/ROS2/Code/Source/VehicleDynamics/Utilities.h Outdated Show resolved Hide resolved
@michalpelka
Copy link
Contributor Author

Thanks, @hultonha and @adamdbrw for reviewing, I agreed and adjusted the code.

@adamdbrw adamdbrw added the feature/robotics This item is related to robotics. label Feb 2, 2023
@michalpelka michalpelka force-pushed the mp/vehicle_dynamic_acceleration branch 2 times, most recently from cf65de4 to 302a7ed Compare February 2, 2023 14:56
@michalpelka
Copy link
Contributor Author

michalpelka commented Feb 2, 2023 •
edited
Loading

Rebased and adjusted to review.

moraaar
moraaar approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@moraaar moraaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. A couple of minor suggestions.

@michalpelka
Added acceleration to vehicle dynamics.
5f1092d 
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
@michalpelka michalpelka force-pushed the mp/vehicle_dynamic_acceleration branch from 302a7ed to 5f1092d Compare February 2, 2023 15:47
@hultonha
Copy link

hultonha commented Feb 3, 2023

Just started another build here, I'll merge when it completes 👍

@michalpelka michalpelka mentioned this pull request Feb 6, 2023
Closed
@hultonha
Copy link

hultonha commented Feb 6, 2023

Just started another build https://jenkins.build.o3de.org/job/o3de-extras/job/PR-102/3/

@hultonha hultonha merged commit 75abcb0 into o3de:development Feb 9, 2023
danielemorra98 pushed a commit to danielemorra98/o3de-extras that referenced this pull request Feb 13, 2023
@michalpelka
Added acceleration to vehicle dynamics. (o3de#102)
b680fd2 
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: Daniele Morra <d50030749@china.huawei.com>
danielemorra98 pushed a commit to danielemorra98/o3de-extras that referenced this pull request Feb 16, 2023
@michalpelka @danielemorra98
Added acceleration to vehicle dynamics. (o3de#102)
c0f8506 
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: danielemorra98 <morradaniele@ymail.com>
danielemorra98 pushed a commit to danielemorra98/o3de-extras that referenced this pull request Feb 20, 2023
@michalpelka @danielemorra98
Added acceleration to vehicle dynamics. (o3de#102)
ee67e54 
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: danielemorra98 <morradaniele@ymail.com>
danielemorra98 pushed a commit to danielemorra98/o3de-extras that referenced this pull request Feb 20, 2023
@michalpelka @danielemorra98
Added acceleration to vehicle dynamics. (o3de#102)
648b823 
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: Daniele Morra <morradaniele@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelbudziszewski pawelbudziszewski pawelbudziszewski left review comments

@spham-amzn spham-amzn spham-amzn approved these changes

@hultonha hultonha hultonha approved these changes

@moraaar moraaar moraaar approved these changes

@adamdbrw adamdbrw adamdbrw approved these changes

@greerdv greerdv Awaiting requested review from greerdv

@SergeyAMZN SergeyAMZN Awaiting requested review from SergeyAMZN

@lemonade-dm lemonade-dm Awaiting requested review from lemonade-dm

Assignees
No one assigned
Labels
feature/robotics This item is related to robotics.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michalpelka @hultonha @adamdbrw @moraaar @pawelbudziszewski @spham-amzn